Re: [taskjuggler-devel] PATCH: fix TestSuite/testdir portability

From: Gerald Pfeifer (gerald_at_pfeifer.com)
Date: Mon Jan 12 2004 - 19:43:24 CET


Date: Mon, 12 Jan 2004 19:43:24 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
Message-ID: <Pine.BSF.4.58.0401121404020.18939@acrux.dbai.tuwien.ac.at>
Subject: Re: [taskjuggler-devel] PATCH: fix TestSuite/testdir portability

On Mon, 12 Jan 2004, Chris Schlaeger wrote:
> Sorry, but this patch breaks the script on Linux. The 'function' is
> correct bash syntax. Where do you have problems with it?

The current script fails whenever /bin/sh is not bash, for example on
FreeBSD.

On which version of Linux did you experience my patch break the script?
(I'm asking because that actually indicates a bug in the bash installation
there.)

GCC includes a script of mine using this portable variant of shell functions
which is regularily used on dozens of platforms, and I have successfully
built and tested TaskJuggler with this patch on a SUSE 9.0 box.

Gerald

PS: Original patch below, in case I was sufficiently convincing. ;-)

ChangeLog:
Avoid BASH-ism in TestSuite/testdir.

--- ./TestSuite/testdir.orig Tue Aug 12 22:48:49 2003
+++ ./TestSuite/testdir Fri Jan 2 13:07:06 2004
@@ -12,7 +12,7 @@ else
   export TASKJUGGLER=../$TASKJUGGLER
 fi

-function do_testing
+do_testing()
 {
   f=$1
   op=$2

-- 
To unsubscribe, email: taskjuggler-devel-unsubscribe@suse.com
For additional commands, email: taskjuggler-devel-help@suse.com


This archive was generated by hypermail 2.1.7 : Mon Jan 12 2004 - 21:49:59 CET