[taskjuggler-devel] HTMLPrimitives.cpp: minor bug fix attached

From: Mike Duskis (mduskis_at_bates.edu)
Date: Mon May 16 2005 - 17:15:49 CEST


Message-ID: <4288B925.5050801@bates.edu>
Date: Mon, 16 May 2005 10:15:49 -0500
From: Mike Duskis <mduskis@bates.edu>
Subject: [taskjuggler-devel] HTMLPrimitives.cpp: minor bug fix attached



I don't know if "bug" is the right word. More likely, there was some
header that was expected to be included but absent.

At any rate, when I tried to build version 2.1, the compiler complained
that "isalpha(char)" in HTMLPrimitives.cpp:315 was undefined:

------------------
for ( ; j < s.length() && isalpha(s[j]); ++j)
                 tagNameLen++;
------------------

I took a guess that the missing function (isalpha(char)) returned true
if and only if the parameter was a valid character for an HTML tag name,
so I changed the code to read

---------------------
for ( ; j < s.length() && ((s[j] >= 'A' && s[j] <= 'Z') || (s[j] >= 'a'
&& s[j] <= 'z') || (s[j] >= '0' && s[j] <= '9')); ++j)
                 tagNameLen++;
---------------------

and now it's building.

Of course, my asumption could be false. I don't see any comments in the
code that could give me a clue.

Regards.

-- 
Mike Duskis
Web Application Developer
Bates College
214-724-9501 (direct)






This archive was generated by hypermail 2.1.7 : Sun May 22 2005 - 01:50:39 CEST