[Deepsea-users] DeepSea 0.7.6

[Joao Eduardo Luis]

On 04/24/2017 10:07 AM, Joshua Schmid wrote:
>
>
> On 24/04/2017 10:27, Joao Eduardo Luis wrote:
>> On 04/24/2017 03:20 AM, Joshua Schmid wrote:
>>>
>>>
>>> On 23/04/2017 15:50, Joao Eduardo Luis wrote:
>>>> On 04/22/2017 02:43 PM, Eric Jackson wrote:
>>>>> Hello everyone,
>>>>>   DeepSea 0.7.6 has been released.  The notable feature is the rolling
>>>>> upgrade.  With a running Ceph cluster, an admin can gracefully upgrade
>>>>> the OS,
>>>>> Salt and Ceph.  See my previous email about specifics.  The CHANGELOG
>>>>> is listed
>>>>> below:
>>>>>
>>>>> - Rolling upgrade
>>>>
>>>> I must say I'm a bit surprised seeing this today, just a single day
>>>> after you gave a "heads up about a large PR to implement the rolling
>>>> upgrade".
>>>>
>>>> Has this behemoth of a PR, with "81 commits and 55 files [...] Several
>>>> of these [... being ...] new" been properly peer-reviewed and discussed?
>>>>
>>>> I ask this because upon checking the PR on github, as well as the merge
>>>> commit, I see no discussion or reviews/Reviewed-by.
>>>>
>>>> It feels strange seeing such a large PR, with roughly 1.4k added lines,
>>>> to be announced one day and merged the very next; especially without
>>>> seeing any sort of involvement from anyone else (beside the authors).
>>>>
>>>
>>> The original commit #43 [https://github.com/SUSE/DeepSea/pull/43] has
>>> quite some comments and was reviewed by Blain. It has been open for a
>>> while now and plenty of discussions with various people have been held.
>>> The fashion in which the Final PR #222 was merged doesn't look as well
>>> reviewed, but it actually is only copy+addendum of #43/162.
>>
>> I apologize for the noise then. It was not obvious such a discussion had
>> been had.
>>
>> In the past, I've found that in cases like these it's useful to have a
>> pointer to the PR where the review process happened. If not for anything
>> else, at least to allow the community around a project to have a sense
>> of transparency. Not everyone follows development, but everyone likes to
>> know where things are coming from when major milestones are reached.
>
> the description of #222, points to #43 and #162 :)
>
> https://github.com/SUSE/DeepSea/pull/222#issue-223528515

Oh well... I promise I read the description before making noise, but 
somehow I overlooked that. My bad.

(I will still point out that neither the 'heads up' email, nor the 
release email, points the consumers to any of those PRs though. I 
actually had to go on github and search for the merge that seemed it 
could be the one.)

   -Joao